Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-82900

Remove variant.h and stdx::variant alias

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 7.3.0-rc0
    • None
    • None
    • Fully Compatible
    • Service Arch 2023-11-13, Service Arch 2023-11-27, Service Arch 2023-12-11

    Description

      Our ::mongo::stdx::variant type used to be a conditional alias, to support different platforms. But as of SERVER-41414 it was no longer conditional, and as of SERVER-77009, it's always std::variant.

      Now that ::mongo::stdx::variant and std::variant are always the same, it means code that incorrectly mixes std::variant with ::mongo::stdx::get or vice versa will not be caught in any build variant. So the alias is no longer giving us the benefit of easily switching implementations.

      Lets remove the alias and find-replace everything to use std::variant directly.

      Attachments

        Activity

          People

            vinod.kumar@mongodb.com Vinod Kumar
            david.percy@mongodb.com David Percy
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: