Audit uses of isVersionInitialized && featureFlag.isEnabled

XMLWordPrintableJSON

    • Catalog and Routing
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Using isEnabledUseLastLTSFCVWhenUninitialized() is more accurate (specifically if there's a feature flag that is enabled by default on the lastLTS FCV). See this doc for an explanation. 

      The goal of this ticket is to:

      1. Understand the impact of replacing calls to isVersionInitialized() && featureFlag.isEnabled() with isEnabledUseLastLTSFCVWhenUninitialized(). Since using isVersionInitialized() && featureFlag.isEnabled() is a general antipattern, the investigation should also incorporate prior versions.
      2. Explore a solution to ensure that new occurrences of the antipattern are not added to the codebase.
      3. Depending on the outcome of (1) & (2), do the actual replacement either as part of this ticket or a followup.

              Assignee:
              Unassigned
              Reporter:
              Huayu Ouyang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: