Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-84253

Refactor MultitenancyCheck

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 8.0.0-rc0
    • None
    • None
    • Fully Compatible
    • Service Arch 2024-01-08, Service Arch 2024-01-22, Service Arch 2024-02-05, Service Arch 2024-02-19
    • 1

    Description

      MultitenancyCheck was added as a workaround to skip $tenant checks in the mongo bridge process. This is because the `op_msg.cpp` is shared between various process (such as mongod, mongos, mongo bridge, etc) and contains a tenant-related check relying on `multitenancySupport`.

      Now that $tenant is being removed `MultitenancyCheck` doesn't really makes sense because we don't use the class to perform checks. Instead we perform an `uassert` on the token if `MultitenancyCheck` exists otherwise we skip the uassert. This produces "correct" logic because the object exists in mongod and mongos but not mongo bridge. However the implementation is not very elegant or clean.

      Attachments

        Activity

          People

            dominic.hernandez@mongodb.com Dominic Hernandez
            didier.nadeau@mongodb.com Didier Nadeau
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: