Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-84360

Refactor SetClusterParameterInvocation::normalizeParameter()

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor - P4 Minor - P4
    • None
    • None
    • None
    • Query Execution

    Description

      Currently, 
      SetClusterParameterInvocation::normalizeParameter() is a public method, which is only used in _configsvrSetClusterParameterCommand implementation.
      I believe it is done most probably only to validate the new cluster parameter value.
       
      I believe we can simplify the SetClusterParameterInvocation and ConfigsvrSetClusterParameterCommand classes by:

      • refactoring the validation out of it,
      • minimizing normalizeParameter() signature (currently it has an extra 'skipValidation' parameter to control the validation) and making it private, and
      • removing the dependency on SetClusterParameterInvocation from ConfigsvrSetClusterParameterCommand.
         

      Attachments

        Activity

          People

            backlog-query-execution Backlog - Query Execution
            romans.kasperovics@mongodb.com Romans Kasperovics
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: