Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-84728

Allow MatchExpression $or -> $in rewrite to preserve parameters

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Optimization
    • QO 2024-02-05, QO 2024-02-19, QO 2024-03-04, QO 2024-03-18, QO 2024-04-01, QO 2024-04-15, QO 2024-04-29, QO 2024-05-13, QO 2024-05-27

      SERVER-84338 disabled the MatchExpression $or->$in rewrite when the equality predicates are parameters. For example (in pseudo-MQL), {$or: [{foo: p1}, {foo: p2}]} cannot be rewritten to {foo: {$in: [p1, p2]}} because InMatchExpression only allows the entire $in operand to be a single parameter. This fixed an edge case in the subplanner which resulted in construction of a residual predicate with incorrect autoparameterization behavior.

      Another solution to that problem is to introduce a new MatchExpression or modify the representation of InMatchExpression parameters in order to allow an InMatchExpression to contain an array of parameters and literals.

      Some questions we'd need to answer to do this ticket:

      • Is the subplanner case in SERVER-84338 the only one where an array of parameters in $in would occur?
      • If so, is the complexity added by implementing this ticket worth the potential performance gain?

            Unassigned Unassigned
            ben.shteinfeld@mongodb.com Ben Shteinfeld
            0 Vote for this issue
            8 Start watching this issue