Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-85735

Make ExternalDataSourceScopeGuard a unique_ptr rather than shared_ptr

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Query Integration

      SERVER-85453 modified the external data source system so that its decoration on the client cursor is effectively a unique_ptr. However, making it a unique_ptr in practice proved to unveil some scope complications that violated intentional lock/operation ordering in run_aggregate.

      We should try to work around that to make it a unique_ptr so we can be confident the scope guard's lifecycle is as expected. We should also consider making it a member field in the client cursor, rather than a decoration (which will require some SCons library refactoring to avoid a dependency).

            Assignee:
            yoonsoo.kim@mongodb.com Yoon Soo Kim
            Reporter:
            will.buerger@mongodb.com Will Buerger
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: