Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-86899

Rename timeseries insert / update / delete functions to reflect operation being performed

    • Type: Icon: Task Task
    • Resolution: Won't Do
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Storage Execution

      An engineer unfamiliar with timeseries code, but familiar with the idea that timeseries performs inserts as updates to bucket documents under the hood, can find the timeseries function names confusing. For example:

      performTimeseriesWrites makes it sound like a function that can handle any type of operation. But it seems like it just handles inserts.
      attemptInsertIntoBucket seems to handle inserts from the name, but is called from insertIntoBucketCatalogForUpdate, so maybe it handles updates.
      Then we have performAtomicWrites which seems to be called for updates / deletes, rather than for inserts, which is how the first function uses the term "writes".

      Though only three functions were named here, we should clean up other functions as well as a part of this ticket.

            Assignee:
            backlog-server-execution [DO NOT USE] Backlog - Storage Execution Team
            Reporter:
            vishnu.kaushik@mongodb.com Vishnu Kaushik
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: