Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-88235

ninja '+' syntax doesn't work for Google benchmarks

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Build
    • None
    • Build

       

      The following ninja invocation results in an error

      ninja +plan_cache_key_encoding_find_bm
      [548/549 ( 99%) 36.134s] Built +plan_cache_key_encoding_bm-plan_cache_key_encoding_find_bm
        --verbose [=arg(=v)]  Log more verbose output.  Specify one or more 'v's to
                              increase verbosity.Unrecognized Argument, see above message for valid mongo arguments or use --help to see valid benchmark arguments.
      FAILED: +plan_cache_key_encoding_bm-plan_cache_key_encoding_find_bm
      rm -f +plan_cache_key_encoding_bm-plan_cache_key_encoding_find_bm; export CCACHE_NOCPP2='1';export CCACHE_PREFIX='/home/ubuntu/mongo/build/scons/icecream/fast/run-icecc.sh';export ICECC_CLANG_REMOTE_CPP='1';export PATH='/opt/mongodbtoolchain/v4/bin:/usr/local/bin:/opt/bin:/bin:/usr/bin';export TMPDIR='/home/ubuntu/mongo/build/tmp_test_data';/bin/icerun build/install/bin/plan_cache_key_encoding_bm -fileNameFilter plan_cache_key_encoding_find_bm
      ninja: build stopped: subcommand failed. 

      It appears that this command is attempting to use the 'fileNameFilter' argument to limit the driver to only run benchmarks defined in a particular file, but Google microbenchmark framework doesn't support this flag.

       

            Assignee:
            daniel.moody@mongodb.com Daniel Moody
            Reporter:
            ben.shteinfeld@mongodb.com Ben Shteinfeld
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: