Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-88914

InstallMockForTestingOrAuthImpl can be removed from AuthorizationSessionImpl

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: None
    • Server Security

      AuthorizationSessionImpl has the following constructor definition:

       struct InstallMockForTestingOrAuthImpl {
              explicit InstallMockForTestingOrAuthImpl() = default;
          };
          explicit AuthorizationSessionImpl(std::unique_ptr<AuthzSessionExternalState> externalState,
                                            InstallMockForTestingOrAuthImpl); 

      There is one constructor, and it never uses InstallMockForTestingOrAuthImpl. All callers have to supply InstallMockForTestingOrAuthImpl.

       

      Because this argument doesn't seem to affect the system, we should remove it.

            Assignee:
            Unassigned Unassigned
            Reporter:
            spencer.jackson@mongodb.com Spencer Jackson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: