InstallMockForTestingOrAuthImpl can be removed from AuthorizationSessionImpl

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: None
    • Server Security
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      AuthorizationSessionImpl has the following constructor definition:

       struct InstallMockForTestingOrAuthImpl {
              explicit InstallMockForTestingOrAuthImpl() = default;
          };
          explicit AuthorizationSessionImpl(std::unique_ptr<AuthzSessionExternalState> externalState,
                                            InstallMockForTestingOrAuthImpl); 

      There is one constructor, and it never uses InstallMockForTestingOrAuthImpl. All callers have to supply InstallMockForTestingOrAuthImpl.

       

      Because this argument doesn't seem to affect the system, we should remove it.

            Assignee:
            Unassigned
            Reporter:
            Spencer Jackson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: