Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-8901

Improvements to DBQuery help(), comment() and some internal refactoring

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Trivial - P5 Trivial - P5
    • 2.5.0
    • 2.4.0-rc2
    • Shell
    • None
    • Minor Change

    Description

      I opened PR#270 some time ago (probably during 2.2's QA). It includes a few small improvements to DBQuery's JS:

      • DBQuery.comment() now returns the DBQuery object instead of chaining to this.next() (consistent with other methods, although maybe this is considered a BC break?)
      • comment(), snapshot(), and readPref() were added to help output
      • Use this._addSpecial() more to remove some code duplication

      If necessary, I can break these apart into smaller commits and/or remove some changes.

      Attachments

        Activity

          People

            jmikola@mongodb.com Jeremy Mikola
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: