Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-89190

Investigate where member variables of ClusterClientCursor and its child classes should go

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Query Integration

      This ticket it to investigate the relationship, potentially move around some member variables, and record in a comment why items should go in the base class vs. the sub-classes. 

      The only derived classes of ClusterClientCursor are ClusterClientCursorImpl and ClusterClientCursorMock. Many member variables are stored in ClusterClientCursorImpl and ClusterClientCursorMock, but the base class ClusterClientCursor also contains a few member variables. 

      It is possible that many of the member variables of ClusterClientCursorImpl could be moved to the base class to simplify things.

      A possible reasoning from this discussion is that you only need to put stuff on the impl (and not the base class) if it involves taking a SCons dependency that we cannot (or don't want to) impose on all users of ClusterClientCursor. This might not be the true reason so this should be investigated. 

            Assignee:
            Unassigned Unassigned
            Reporter:
            erin.zhu@mongodb.com Erin Zhu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: