Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-90215

Remove extraneous invariants from future_impl.h

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Replication
    • Execution Team 2024-05-13, Execution Team 2024-05-27, Execution Team 2024-06-10, Execution Team 2024-06-24, Execution Team 2024-07-08, Execution Team 2024-07-22, Execution Team 2024-08-05, Execution Team 2024-08-19, Execution Team 2024-09-02, Execution Team 2024-09-16, Execution Team 2024-09-30, Execution Team 2024-10-14, Execution Team 2024-10-28, Execution Team 2024-11-11, Execution Team 2024-11-25, Execution Team 2024-12-09, Execution Team 2024-12-23

      In the server code, we generally don't add invariants to defend against null pointer exceptions before dereferences, as there is little benefit over having a segmentation violation.

      In the spirit of all bits help, I found that removing these few invariants remove about 1% of time for ServiceEntryPointCommonBenchmarkFixture/BM_SEP_PING.

            Assignee:
            geert.bosch@mongodb.com Geert Bosch
            Reporter:
            geert.bosch@mongodb.com Geert Bosch
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: