Move SearchSharedState off ExpressionContext

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Major - P3
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Integration
    • Fully Compatible
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      1. Move SearchSharedState off ExpressionContext into DocumentSourceInternalSearchIdLookup header, and it might be worth considering renaming the struct since "SearchSharedState" is pretty vague. What about "SearchIdLookupMetrics"?
      2. IdLookup can construct its own instance of the struct, and then DocumentSourceInternalSearchMongotRemote needs a pointer to the struct. This Is the function where we "desugar" a $search stage into the separate $internalSearchMongotRemote and $_internalSearchIdLookup stages, and we'll need to pass the pointer from idLookup to mongotRemote. If we're _not using an idLookup stage (if the query is "storedSource"), then mongot remote can have a nullptr.
      3. Will need to move the test from the previous ticket form expression context to idLookup, but the integrity of the test should be able to remain.

            Assignee:
            Joe Shalabi
            Reporter:
            Will Buerger
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: