Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-94002

Non-pit logic in should_run_backup_or_restore seems incorrect.

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Replication
    • Repl 2024-09-02, Repl 2024-09-16, Repl 2024-09-30

      should_run_backup_or_restore is doing

      # For non point in time restores we want to do the backup and restore after the same test.
      else:            
          return (self.tests_run < self.n, self.tests_run < self.n)
      

      It should probably be

      (self.tests_run == self.n, self.tests_run == self.n) ?
      

      If n == 10 and tests_run == 1, it should be (false, false).
      Also if n == 1 and tests_run == 1, it should be (true, true).

            Assignee:
            ali.mir@mongodb.com Ali Mir
            Reporter:
            frederic.vitzikam@mongodb.com Frederic Vitzikam
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: