Non-pit logic in should_run_backup_or_restore seems incorrect.

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Major - P3
    • 8.1.0-rc0, 8.0.5
    • Affects Version/s: None
    • Component/s: None
    • None
    • Replication
    • Fully Compatible
    • v8.0
    • Repl 2024-09-02, Repl 2024-09-16, Repl 2024-09-30
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      should_run_backup_or_restore is doing

      # For non point in time restores we want to do the backup and restore after the same test.
      else:            
          return (self.tests_run < self.n, self.tests_run < self.n)
      

      It should probably be

      (self.tests_run == self.n, self.tests_run == self.n) ?
      

      If n == 10 and tests_run == 1, it should be (false, false).
      Also if n == 1 and tests_run == 1, it should be (true, true).

            Assignee:
            Ali Mir
            Reporter:
            Frederic Vitzikam (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: