Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-94870

Improve maintainability of the cluster rename path

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Catalog and Routing
    • 3

      The cluster rename path is currently relying on several commands and helpers to validate the incoming requests and rename the metadata. Conversions between requests and helpers are called ad-hoc in several points in the path, making the code hard to maintain. 

      In order to validate and rename the metadata, we need to convert any request into options

      The latter changes according to operation: some fields are required for renaming but not for validating. 

      The validation is performed in several points, and a missing validation will cause the coordinator to retry indefinitely as the commit phase (specifically, the local rename) is always expected to succeed.

      Goal

      The current structure of the code makes it impossible for the developer to know how to correctly build the options. The goal is to propose a refactoring to clear which parameters are required in any point. 

            Assignee:
            Unassigned Unassigned
            Reporter:
            enrico.golfieri@mongodb.com Enrico Golfieri
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: