Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-95216

Clean up duplicate code ownership definitions for client_cursor

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Trivial - P5 Trivial - P5
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: Internal Code
    • None
    • Query Execution
    • Fully Compatible
    • QE 2024-10-14

      SERVER-92811 moved files related to client cursors into a new subdirectory `src/mongo/db/query/client_cursor`. The code ownership for the files in there was also transferred to the new directory.

      The commit that moved the files and the code ownership was [70970f374080c647ddc65500b98bd7ae5286db97|https://github.com/10gen/mongo/commit/70970f374080c647ddc65500b98bd7ae5286db97.]

       

      A later commit readded code ownership for the moved files back in the `src/mongo/db` directory. This was likely done by mistake, as the two changes overlapped in time during their development and likely caused merge conflicts.

      Now the code ownership for some of the cursor files in `src/mongo/db/query/client_cursor` is defined in two different places:

      • `src/mongo/db/query/client_cursor/OWNERS.yml` (correct place)
      • `src/mongo/db/OWNERS.yml` (incorrect place)

      We should clean this up by removing the code ownership for cursor files from the latter place.

      This affects the following glob patterns:

      • "allocate_cursor_id*"
      • "clientcursor*"
      • "cursor_id.h"
      • "cursor_manager*"
      • "cursor_server_params*"
      • "exhaust_cursor_currentop_integration_test.cpp"

            Assignee:
            jan.steemann@mongodb.com Jan Steemann
            Reporter:
            jan.steemann@mongodb.com Jan Steemann
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: