Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-95379

Get rid of TestData.useActionPermittedFile

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Correctness

      It's possible for an engineer to introduce a hook that uses the FileBasedThreadLifecycle object, and then forget to set TestData.useActionPermittedFile which instructs the FSM framework to create / delete the files required to coordinate the hook's actions with the tests.

      When we forget to set the TestData useActionPermittedFile variable, the hook ends up doing nothing silently. This means we won't be getting the test coverage we think we're getting.

      we should do away with the additional variable and get things to work without it. If that's not possible, we should add a linter / some other check that complains when a hook using the FileBasedThreadLifecycle is being run without the variable being set.

            Assignee:
            Unassigned Unassigned
            Reporter:
            vishnu.kaushik@mongodb.com Vishnu Kaushik
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: