Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-95471

remove geo object warnings

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution

      In expression_keys_private.cpp there are two log warnings that are possible:
      1.

              LOGV2_WARNING_OPTIONS(6118400,
                                    {logv2::UserAssertAfterLog(ErrorCodes::CannotBuildIndexKeys)},
                                    "Insert of geo object exceeded maximum number of generated keys",
                                    "obj"_attr = redact(obj));
      

      2.

              LOGV2_WARNING(23755,
                            "Insert of geo object generated a large number of keys",
                            "obj"_attr = redact(obj),
                            "numKeys"_attr = keysToAdd.size());
      

      These warnings are not very helpful to anyone, as log lines are typically only used to diagnose a problem; they aren't proactively scanned for potential issues.
      Since neither of these log lines have obvious corrective actions, and since both of these log lines log the entire object being inserted, which by their nature will be extremely large, the amount of data being inserted into the log can be so voluminous that it affects performance and can exhaust free disk space.
      Since the utility of these log lines is so low, we should just remove them.

            Assignee:
            Unassigned Unassigned
            Reporter:
            milkie@mongodb.com Eric Milkie
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: