Using WithLock is safer because it forces us to actually have a lock rather than simply expect the engineers will do the right thing and acquire the lock before calling. Example: https://github.com/mongodb/mongo/blob/f876f3c121484c7d66dc622d662a7aa25f5c9c6f/src/mongo/client/replica_set_monitor_manager.cpp#L152