Improve type safety of PlanStageKey

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Query Optimization
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      In SERVER-95112, we introduced PlanStageKey to represent an identifier for a PlanStage which could be used in a map. It was typedef'd to PlanStage*, but the intention was to never dereference this pointer, as this key may outlive the PlanStage itself. The compiler currently will not warn on accidently dereferencing this type.

      We can improve this by making PlanStageKey an uint64_t.

              Assignee:
              Unassigned
              Reporter:
              Ben Shteinfeld
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: