Refactor: Replace ASSERT_CE_APPROX_EQUAL with ASSERT_APPROX_EQUAL

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Major - P3
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Optimization
    • Fully Compatible
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      ASSERT_CE_APPROX_EQUAL is a thin wrapper on top of ASSERT_APPROX_EQUAL. It converts a CE value to double (via static_cast<double>) before comparing. This is used by previous CEType (defunct) and does not work with new strong type alias CardinalityEstimate any more. All the uses of ASSERT_CE_APPROX_EQUAL already have operands as doubles and we should simply use ASSERT_APPROX_EQUAL.

      Remove ASSERT_CE_APPROX_EQUAL and replace all the call sites with ASSERT_APPROX_EQUAL.

              Assignee:
              Matt Olma
              Reporter:
              Chi-I Huang
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: