Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-97062

Enable clang-tidy checks for anonymous namespaces and strong definitions in headers

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Server Programmability
    • Fully Compatible
    • 200

      Anonymous namespaces and non-inline, non-templated definitions of variables and functions in headers are an easy to type source of ODR violations. Several instances have crept into our codebase. We should enable the (unfortunately named) google-build-namespaces, and misc-definitions-in-headers clang-tidy checks and scrub out all existing cases.

            Assignee:
            mathias@mongodb.com Mathias Stearn
            Reporter:
            mathias@mongodb.com Mathias Stearn
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: