Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-97620

PipelineDataSource gets passed around with pipeline in sharded agg code when it could be determined from the pipeline.

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution

      the example that made me think of this is https://github.com/mongodb/mongo/blob/c9cdc22691d53870264c7491d899d82cc02ac56c/src/mongo/s/query/planner/cluster_aggregation_planner.cpp#L767 like if we pass it the pipeline this seems like something that could just be a helper on the pipeline and liteParsed pipeline class.

       

      if it cannot be implemented like that maybe it could be part of a common sharded agg planning state object, it seems like we are doing a lot of prop drilling in this code and this is one example where we could get rid of an arg alltogether

            Assignee:
            Unassigned Unassigned
            Reporter:
            mickey.winters@mongodb.com Mickey Winters
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: