Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-98504

Remove any usage of trackUnshardedUponCreation feature flag

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Catalog and Routing

      Context
      The feature flag trackUnshardedCollectionsUponCreation is currently disabled in production. The code behind the feature flag still requires to see the completion of another project which won't make it for v9.0.  Meanwhile, the feature flag is still tested in the all-feature-flag build variant and It's currently known to cause a possible deadlock (SERVER-95544).

      This ticket is a second part of a plan to fully remove the usage of trackUnshardedCollectionsUponCreation from our testing environment. 

      The plan
      Part 1: SERVER-97468

      • Fully disabled the trackUnshardedCollectionsUponCreation from testing.
      • It isolates the tracking of collection upon creation within specific suites (required for keep running operations on already tracked collections):
        • aggregation_unsplittable_collections_on_random_shard_passthrough
        • unsplittable_collections_created_on_any_shard_jscore_passthrough
        • unsplittable_collections_on_random_shard_jscore_txns
      • The suites do not require the feature flag to be enabled in order to track a collection upon creation.

      Part 2: SERVER-98123 Enable failpoint in aggregation_unsplittable_collections_on_random_shard_passthrough_with_config_transitions

      • Must continue the work of SERVER-97468 and enable the tracking upon creation in the aggregation_unsplittable_collections_on_random_shard_passthrough_with_config_transitions suite
      • This suite is generating specific errors that must be solved 

      Part 3: (this ticket)

      Once a good coverage is guaranteed by the suites, we can safely remove the feature flag

      • Remove any usage of trackUnshardedCollectionsUponCreation
      • Test cases that rely on the feature flag when enabled can be removed

       

      After this ticket, the following is expected:

      • Tracking upon creation is disabled in production
      • Tracking upon creation is enabled in testing, isolated in specific suites

            Assignee:
            enrico.golfieri@mongodb.com Enrico Golfieri
            Reporter:
            enrico.golfieri@mongodb.com Enrico Golfieri
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: