Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-9878

Add safety checks to V8 C++ bindings

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major - P3
        • Resolution: Fixed
        • Affects Version/s: 2.4.4
        • Fix Version/s: 2.4.5, 2.5.1
        • Component/s: JavaScript
        • Labels:
          None
        • Backwards Compatibility:
          Minor Change
        • Operating System:
          ALL

          Issue Links

          is depended on by

          Sub-task - The sub-task of the issue SERVER-9582 V8 allows DBRef() with no arguments

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

            Activity

            • Comments
            Ascending order - Click to sort in descending order
            Hide
            Permalink
            auto auto (Inactive) added a comment -

            Author:

            {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

            Message: SERVER-9878 Add type checks to V8 C++ bindings

            The main focus of this ticket is tightening up input validation in
            our V8 bindings. Doing this required normalizing the way we create
            custom types in JS that have special C++-driven behavior. All special
            types now use FunctionTemplates that are attached to the V8Scope object.
            This allows us to test if an object is of the correct type before using
            it.

            Other related tickets partially addressed:
            SERVER-8961 Differences in argument validation of custom types between v8 and Spidermonkey
            SERVER-9803 Handle regular expression parse errors without seg faulting
            Branch: master
            https://github.com/mongodb/mongo/commit/fda4a2342614e4ca1fb26c868a5adef0e050eb5e

            Show
            auto auto (Inactive) added a comment - Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'} Message: SERVER-9878 Add type checks to V8 C++ bindings The main focus of this ticket is tightening up input validation in our V8 bindings. Doing this required normalizing the way we create custom types in JS that have special C++-driven behavior. All special types now use FunctionTemplates that are attached to the V8Scope object. This allows us to test if an object is of the correct type before using it. Other related tickets partially addressed: SERVER-8961 Differences in argument validation of custom types between v8 and Spidermonkey SERVER-9803 Handle regular expression parse errors without seg faulting Branch: master https://github.com/mongodb/mongo/commit/fda4a2342614e4ca1fb26c868a5adef0e050eb5e
            Hide
            Permalink
            auto auto (Inactive) added a comment -

            Author:

            {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

            Message: SERVER-9878 Add type checks to V8 C++ bindings

            The main focus of this ticket is tightening up input validation in
            our V8 bindings. Doing this required normalizing the way we create
            custom types in JS that have special C++-driven behavior. All special
            types now use FunctionTemplates that are attached to the V8Scope object.
            This allows us to test if an object is of the correct type before using
            it.

            Other related tickets partially addressed:
            SERVER-8961 Differences in argument validation of custom types between v8 and Spidermonkey
            SERVER-9803 Handle regular expression parse errors without seg faulting

            Conflicts:

            jstests/constructors.js
            src/mongo/scripting/engine_v8.cpp
            Branch: v2.4
            https://github.com/mongodb/mongo/commit/7c1b35e0b2cc69c93074c6d1d76879b3ed525f56

            Show
            auto auto (Inactive) added a comment - Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'} Message: SERVER-9878 Add type checks to V8 C++ bindings The main focus of this ticket is tightening up input validation in our V8 bindings. Doing this required normalizing the way we create custom types in JS that have special C++-driven behavior. All special types now use FunctionTemplates that are attached to the V8Scope object. This allows us to test if an object is of the correct type before using it. Other related tickets partially addressed: SERVER-8961 Differences in argument validation of custom types between v8 and Spidermonkey SERVER-9803 Handle regular expression parse errors without seg faulting Conflicts: jstests/constructors.js src/mongo/scripting/engine_v8.cpp Branch: v2.4 https://github.com/mongodb/mongo/commit/7c1b35e0b2cc69c93074c6d1d76879b3ed525f56

              People

              • Assignee:
                redbeard0531 Mathias Stearn
                Reporter:
                redbeard0531 Mathias Stearn
                Participants:
                Last commenter:
                Ramon Fernandez
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Days since reply:
                  3 years, 14 weeks, 3 days ago
                  Date of 1st Reply: