Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-98947

vcxproj script does not generate mongodb.vcxproj.filters file correctly

    • Type: Icon: Bug Bug
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Build
    • ALL

      SERVER-93705 already partially fixed an issue with the script which starting failing after compile_commands.json compiler paths were changed to full paths, however, it did not fully fix the problem because now the path can contain both '\' and '/' as directory delimiter, making the regular expression currently used to fail. We could solve this by changing the regex applying the following diff:

      diff --git a/buildscripts/make_vcxproj.py b/buildscripts/make_vcxproj.py
      index 9d838888f73..e57f4d5d964 100644
      --- a/buildscripts/make_vcxproj.py
      +++ b/buildscripts/make_vcxproj.py
      @@ -248,7 +248,7 @@ class ProjFileGenerator(object):
           def __parse_cl_line(self, line):
               """Parse a compiler line."""
               # Get the file we are compilong
      -        file_name = re.search(r"/c ([\w\\.-]+)", line).group(1)
      +        file_name = re.search(r"/c ([\w\\\/.-]+)", line).group(1).replace("/", "\\")
      
               # Skip files made by scons for configure testing
               if "sconf_temp" in file_name:
      

            Assignee:
            Unassigned Unassigned
            Reporter:
            marcos.grillo@mongodb.com Marcos José Grillo Ramirez
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: