-
Type:
Improvement
-
Resolution: Fixed
-
Priority:
Major - P3
-
Affects Version/s: None
-
Component/s: None
-
None
-
Query Execution
-
Fully Compatible
-
None
-
3
-
None
-
None
-
None
-
None
-
None
-
None
The getIndexForExpressEquality() function is complex and difficult to reason about and thus is fertile ground for bugs. It could be improved by (for example) separating and naming the compound boolean checks. We might also consider re-working the loop structure to make it more explicit that we're looking for best choice and skipping over ineligible ones during each pass.