Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-99593

feature_flag_tags_check.py should correctly account fully disabled feature flags

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Correctness
    • Fully Compatible
    • ALL
    • 2025-02-04, 2025-02-18

      Looks like feature_flag_tags_check.py doesn't see a difference between fully disabling feature flag and enabling the feature flag by default

      This patch failure shows the case when feature flag was fully disabled and check_feature_flag_tags task failed, because several tests were tagged with the feature flag
      https://parsley.mongodb.com/evergreen/mongodb_mongo_master_amazon_linux2_arm64_static_compile_check_feature_flag_tags_patch_a5c48b1e0831e15bcab30a40bdf6868803eb6834_6789337943192300073688b4_25_01_16_16_31_40/0/task?bookmarks=0,1783,1786,1787,1788,1789,1791,1792,1793,1794,2267

      Given this comment all tests that are tagged with fully disabled feature flags are disabled from running on all variants:
      https://github.com/10gen/mongo/blob/78e54d7f0ecc6002324b6479bde10f7e1e195e85/buildscripts/resmokeconfig/fully_disabled_feature_flags.yml#L2

      That means that adding feature flag to the list of fully disabled feature flags should not require any action to JS tests that are tagged with such feature flag.

      Slack thread
      https://mongodb.slack.com/archives/C07T35KELLC/p1737065211212339

            Assignee:
            juan.gu@mongodb.com Juan Gu
            Reporter:
            mikhail.shchatko@mongodb.com Mikhail Shchatko
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: