Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-99599

legacy_commands_check.py reports false positives

XMLWordPrintableJSON

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Cluster Scalability
    • Fully Compatible
    • ALL

      The script just searches for substrings and failed the check when I made a change to mongod_main.cpp, where it declares a subclass of CommandInvocationHooks which clearly shouldn't be reported. We should consider matching ""public Command {" instead, or use regexes to match whole word.

            Assignee:
            david.chen@mongodb.com David Chen
            Reporter:
            wei.hu@mongodb.com Wei Hu
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: