Error checking in the `MongoDump.Dump` func is backwards

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • 1
    • Tools and Replicator
    • 2
    • Needed

      At lines 474-482, we have this code:

      exists, err := dump.checkOplogTimestampExists(dump.oplogStart)
		if !exists {
			return fmt.Errorf(
				"oplog overflow: mongodump was unable to capture all new oplog entries during execution",
			)
		}
		if err != nil {
			return fmt.Errorf("unable to check oplog for overflow: %v", err)
		}

      Checking exists before err is backwards and produces confusing results.

            Assignee:
            Dave Rolsky
            Reporter:
            Dave Rolsky
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: