Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-11097

Layering violation and potential dead code in wt_gen_drain

    • Type: Icon: Technical Debt Technical Debt
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Labels:
    • 3
    • StorEng - Defined Pipeline

      In __wt_gen_drain, there is a check on the generation variable to know whether it's WT_GEN_EVICT or WT_GEN_CHECKPOINT to enable more logs when we are about to timeout. There are two issues related to this:

      • The generation code should not reference specific users. It is supposed to be a generic implementation used by different codes. We should look into removing those checks.
      • The other issue is the potential dead code related to the WT_GEN_CHECKPOINT section. Indeed, it seems that _wt_gen_drain is called by _wt_gen_next_drain which is only called with WT_GEN_EVICT. By fixing the first bullet point, this one should disappear.

            Assignee:
            backlog-server-storage-engines [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            etienne.petrel@mongodb.com Etienne Petrel
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: