s_python gives false positives due to build artifacts

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Minor - P4
    • WT11.3.0, 7.3.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Storage Engines
    • 2024-01-09 - I Grew Tired
    • 3

      The s_python script does not limit itself to inspecting files tracked by git, and can end up looking in build directories. For example:

      ####################### MESSAGE ############################
      s_all run of: "./s_python" resulted in:
          [tab] characters appear in Python scripts:
          	./build/bench/wtperf/venv/lib/python3.10/site-packages/psutil/tests/test_linux.py
          	./build/bench/wtperf/venv/lib/python3.10/site-packages/wheel/macosx_libfile.py
      

      Rather than simply finding each Python file, we should either use git, or an allowlist approach like comment_style.py. Note that if using git, there needs to be a fallback - we can't always assume the command is being run from within a git repository (e.g. for the standalone release tarball).

            Assignee:
            Adeline Chen
            Reporter:
            Will Korteland
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: