Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-11823

Fix test_salvage02 for the tiered and timestamp hooks

    • 1
    • Joker - StorEng - 2023-10-17

      Unexpected fallout from WT-11721 after adding a new python test test_salvage02.

      It passes all PR testing, however on mainline when run with -hook tiered we hit failures because salvage isn't compatible with tiered storage. This test shouldn't be executed under -hook tiered, but the skip logic in hook_tiered.py::filter_tests is too specific and only skips test_salvage01 instead of all tiered tests.

      We need to update hook_tiered to correctly skip this test.

      There also seems to be a similar issue where --hook timestamp skips test_salvage01 but not test_salvage02.

       

      unit-test-hook-tiered-timestamp on ubuntu2004

      Host: i-0f14959564498dd46
      Project: wiredtiger
      Commit: 4ea541c4

      Task Logs:

      unit-test-hook-tiered-timestamp task_log

      Logs:

      [pid:3194]: FAIL: test_salvage02.test_salvage02.test_hs_removed(row_integer)
      ----------------------------------------------------------------------
      [pid:3194]: testtools.testresult.real._StringException: Traceback (most recent call last):
        File "/data/mci/e9ee4226bd35d316407e42dcd07b62e3/wiredtiger/test/suite/wttest.py", line 229, in _callTestMethod
          method()
        File "/data/mci/e9ee4226bd35d316407e42dcd07b62e3/wiredtiger/test/suite/test_salvage02.py", line 69, in test_hs_removed
          assert(len(results) == nrows)
      AssertionError
      ======================================================================
      [pid:3194]: FAIL: test_salvage02.test_salvage02.test_hs_removed(column)
      ----------------------------------------------------------------------
      [pid:3194]: testtools.testresult.real._StringException: Traceback (most recent call last):
        File "/data/mci/e9ee4226bd35d316407e42dcd07b62e3/wiredtiger/test/suite/wttest.py", line 229, in _callTestMethod
          method()
        File "/data/mci/e9ee4226bd35d316407e42dcd07b62e3/wiredtiger/test/suite/test_salvage02.py", line 69, in test_hs_removed
          assert(len(results) == nrows)
      AssertionError
      ----------------------------------------------------------------------
      Ran 2063 tests in 1769.043s
      

      logs

            Assignee:
            andrew.morton@mongodb.com Andrew Morton
            Reporter:
            Xgen-BuildBaron-User xgen-buildbaron-user
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: