Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-11844

Silently sort s_string.ok and spell.ok

    • Type: Icon: Technical Debt Technical Debt
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • WT11.2.0, 7.2.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
    • 2
    • Asparagus-StorEng - 2023-10-31

      To reproduce the issue with s_string.ok, insert an out-of-order entry in that file:

      diff --git a/dist/s_string.ok b/dist/s_string.ok
      index f266c82557..be12213b0d 100644
      --- a/dist/s_string.ok
      +++ b/dist/s_string.ok
      @@ -439,8 +439,8 @@ WriteFile
       Wundef
       Wuninitialized
       Wunused
      -XP
       Xorshift
      +XP
       YCSB
       ZSTD
       Zlib
      

      Then run s_string and the following should spam your terminal:

      ~/wiredtiger/dist$ ./s_string
      comm: file 2 is not in sorted order
      comm: file 2 is not in sorted order
      comm: file 2 is not in sorted order
      comm: file 2 is not in sorted order
      comm: file 2 is not in sorted order
      comm: file 2 is not in sorted order
      comm: file 2 is not in sorted order
      comm: file 2 is not in sorted order
      comm: file 2 is not in sorted order
      ...
      

      We could simply error out if the file is not sorted or sort it in place.

            Assignee:
            etienne.petrel@mongodb.com Etienne Petrel
            Reporter:
            etienne.petrel@mongodb.com Etienne Petrel
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: