Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-12240

Unnecessary check in __wt_txn_visible_all

XMLWordPrintableJSON

    • Type: Icon: Technical Debt Technical Debt
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Labels:
    • 3
    • StorEng - Defined Pipeline

      In __wt_txn_visible_all, we have a check:

          /*
     * When shutting down, the transactional system has finished running and all we care about is
     * eviction, make everything visible.
     */
    if (F_ISSET(S2C(session), WT_CONN_CLOSING))
        return (true);

      I think this is no long necessary as the eviction thread now has its own snapshot and should be able to see everything when closing down. Review whether we can remove this check. It should improve our runtime performance.

            Assignee:
            backlog-server-storage-engines [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            chenhao.qu@mongodb.com Chenhao Qu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: