Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-12934

Work around remaining git diff issues on 0-length files effecting code change reports

    • Storage Engines
    • 2
    • Megabat - 2024-05-14

      During her work on WT-12837, jasmine.bi@mongodb.com has encountered issue triggered by some 0-length files that are being added as part of her PR.

      For patch builds, the Code Change Report creates a git diff between the patch and develop. If this contains newly added 0-length files then the pygit2 Python library used in the Code Change Report code fails to load the diff causing the task to fail.

      WT-12868 created a workaround for newly added 0-length files, however Jasmine's PR also has some deleted 0-length files. Each of these files can generate either a deleted file record in the diff, or it may generate a record moving that file to another location as it sees a match in the (0-length) content.

      The solution is to also exclude from the diff output file:

      • Any deleted files
      • Any moved files where the record includes the path of a 0-length file.

       

            Assignee:
            jeremy.thorp@mongodb.com Jeremy Thorp
            Reporter:
            jeremy.thorp@mongodb.com Jeremy Thorp
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: