Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-1294

JSON import lint

    • Type: Icon: Task Task
    • Resolution: Done
    • WT2.4.1
    • Affects Version/s: None
    • Component/s: None
    • Labels:

      Don, I'm moving the lint complaints about the JSON code into an issue so they don't get lost, can you please take a look? Some of these may be lint asking for the impossible, feel free to ignore what isn't worth fixing.

      < --- Module:   src/utilities/util_load_json.c (C)
      <                                                               _
      <                               config_list_add(&cl, tableuri);
      < src/utilities/util_load_json.c  373  Warning 534: Ignoring return value of
      <     function 'config_list_add(CONFIG_LIST *, char *)' (compare with line 177,
      <     file src/utilities/util_load.c)
      < src/utilities/util_load.c  177  Info 830: Location cited in prior message
      <                                                             _
      <                               config_list_add(&cl, config);
      < src/utilities/util_load_json.c  374  Warning 534: Ignoring return value of
      <     function 'config_list_add(CONFIG_LIST *, char *)' (compare with line 177,
      <     file src/utilities/util_load.c)
      < src/utilities/util_load.c  177  Info 830: Location cited in prior message
      <                                            _
      <                   JSON_INPUT_POS(ins) + 1,
      < src/utilities/util_load_json.c  495  Warning 559: Size of argument no. 5
      <     inconsistent with format
      <                                                          _
      <                       if ((hit = strstr(ins->p, *match)) != NULL)
      < src/utilities/util_load_json.c  521  Error 158: Assignment to variable 'hit'
      <     (line 512) increases capability
      
      729,749d699
      < Info 759: header declaration for symbol 'config_read(char ***, int *)' defined
      <     at (line 207, file src/utilities/util_load.c) could be moved from header to
      <     module
      < src/utilities/util_load.c  207  Info 830: Location cited in prior message
      < Info 765: external 'config_read(char ***, int *)' (line 207, file
      <     src/utilities/util_load.c) could be made static
      < src/utilities/util_load.c  207  Info 830: Location cited in prior message
      < Info 759: header declaration for symbol 'config_remove(char *, const char *)'
      <     defined at (line 481, file src/utilities/util_load.c) could be moved from
      <     header to module
      < src/utilities/util_load.c  481  Info 830: Location cited in prior message
      < Info 765: external 'config_remove(char *, const char *)' (line 481, file
      <     src/utilities/util_load.c) could be made static
      < src/utilities/util_load.c  481  Info 830: Location cited in prior message
      < Info 759: header declaration for symbol 'config_rename(char **, const char *)'
      <     defined at (line 450, file src/utilities/util_load.c) could be moved from
      <     header to module
      < src/utilities/util_load.c  450  Info 830: Location cited in prior message
      < Info 765: external 'config_rename(char **, const char *)' (line 450, file
      <     src/utilities/util_load.c) could be made static
      < src/utilities/util_load.c  450  Info 830: Location cited in prior message
      

            Assignee:
            donald.anderson@mongodb.com Donald Anderson
            Reporter:
            keith.bostic@mongodb.com Keith Bostic (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: