Remove/resolve unused functions in WT

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Duplicate
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Lint
    • Security Level: Public (Available to anyone on the web)
    • Storage Engines, Storage Engines - Foundations
    • 9,017.2
    • None
    • None

      For expediency in getting a green build for better workflow, SLS-438 disabled several scripts.  Among them is s_funcs.  When that script is run the result is:

      $ cd dist
      $ bash s_funcs
      __wt_block_disagg_manager_drop
      __wt_block_pantry_manager_drop
      __wt_oligarch_log_compat_verify
      __wt_oligarch_log_flush
      __wt_oligarch_log_get_backup_files
      __wt_oligarch_log_needs_recovery
      __wt_oligarch_log_reset
      __wt_oligarch_log_system_backup_id
      __wt_oligarch_log_written_reset
      __wt_txn_checkpoint_oligarch_log
      __wt_txn_checkpoint_oligarch_logread
      __wt_txn_oligarch_op_free
      __wt_txn_oligarch_printlog
      __wt_txn_ts_oligarch_log 

      These are functions that are defined in WT, but never called.  Normally this is a bug that is a coding oversight.  In these cases, most/all of these are probably resulting from cloning some subsystem to make a disagg or oligarch version of that subsystem that can be modified without messing up the "vanilla WT" version of the subsystem.  Sometimes this results in functions not (immediately) being used.  We should investigate all of these, and over time, resolve them by either using them, removing them, or possibly in a rare case, putting it into the exception list.

            Assignee:
            [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            Donald Anderson
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: