-
Type:
Technical Debt
-
Resolution: Unresolved
-
Priority:
Minor - P4
-
None
-
Affects Version/s: None
-
Component/s: Block Manager
-
Security Level: Public (Available to anyone on the web)
-
Storage Engines - Persistence
-
8,630.789
-
SE Persistence backlog
-
8
Most existing B-Tree code (e.g. in bt_ovfl.c, bt_slvg.c, etc) callsĀ __wt_bm_read_page to get a page. This makes sense, because deltas should be hidden in the block manager layer.
However, disagg has added __wt_bm_read_multi, which explicitly returns the base image plus its deltas, and the caller must reassemble them.
This kinda makes sense too, since the block manager shouldn't have to know about page structure, and how to reassemble pages. However, it leaves us with an awkward design - every bit of code that calls the block manager needs to know whether it must reassemble a page.
At the moment this is manifested as _wt_bm_read_page asserting that it hasn't got any deltas (FIXME-WT-14608, src/block_mgr/block_io.c). That works because, for the current disagg implementation, we only need to call _wt_bm_read_multi from one spot (bt_read.c). But that's not going to be the case forever.
Originally filed against the legacy block cache's wt_blkcache_read / wt_blkcache_read_multi; both were renamed with the block cache removal in WT-19017
- is related to
-
WT-19017 Merge legacy block cache deprecation feature branch into develop
-
- Closed
-