Details

    • Type: Task
    • Status: Resolved
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: WT2.7.0

      Description

      We need to distinguish between closing the underlying (btree) handle and removing the data handle from the shared hash table.

        Issue Links

          Activity

          Hide
          michael.cahill Michael Cahill added a comment -

          Sue LoVerso, I believe this is now done with the distinction between dh_conn_ref and dh_session_handles. Can you please confirm and close this issue if you agree?

          BTW, I don't much like the short names of those stats if you want to suggest alternatives.

          Show
          michael.cahill Michael Cahill added a comment - Sue LoVerso , I believe this is now done with the distinction between dh_conn_ref and dh_session_handles . Can you please confirm and close this issue if you agree? BTW, I don't much like the short names of those stats if you want to suggest alternatives.
          Hide
          sue.loverso Sue LoVerso added a comment -

          I think you meant dh_conn_ref and dh_conn_handles - I agree that those count the items listed in this ticket. However I believe there are two problems with this. The use of db_conn_ref is incorrect. It was incorrectly changed when sweep was split into two parts with this changeset https://github.com/wiredtiger/wiredtiger/commit/269e847ad64dd12dfcadb58f84f905069e5b8dce.

          The purpose of db_conn_ref is to count the times that we find an idle handle and after we lock it we discover the handle became referenced and used again. I think that may also have motivated your suggestion about the name. The name is okay in the proper usage and context.

          Therefore, once that fix is made there will not be a statistic that indicates the number of time we remove a dhandle from the hash list. The dh_conn_handles does count the number of handles we close. I will fix those two things.

          Show
          sue.loverso Sue LoVerso added a comment - I think you meant dh_conn_ref and dh_conn_handles - I agree that those count the items listed in this ticket. However I believe there are two problems with this. The use of db_conn_ref is incorrect. It was incorrectly changed when sweep was split into two parts with this changeset https://github.com/wiredtiger/wiredtiger/commit/269e847ad64dd12dfcadb58f84f905069e5b8dce . The purpose of db_conn_ref is to count the times that we find an idle handle and after we lock it we discover the handle became referenced and used again. I think that may also have motivated your suggestion about the name. The name is okay in the proper usage and context. Therefore, once that fix is made there will not be a statistic that indicates the number of time we remove a dhandle from the hash list. The dh_conn_handles does count the number of handles we close. I will fix those two things.
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'}

          Message: WT-1481 Fix and clarify some sweep statistics.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/aa3257dec471e7ce853de69d094d9a6cdc39ca23

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'} Message: WT-1481 Fix and clarify some sweep statistics. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/aa3257dec471e7ce853de69d094d9a6cdc39ca23
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'}

          Message: WT-1481 Fix statistics name usage in tests.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/ec69f4ea7542607eab984d3904f527ec24d4f6e0

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'sueloverso', u'name': u'Susan LoVerso', u'email': u'sue@wiredtiger.com'} Message: WT-1481 Fix statistics name usage in tests. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/ec69f4ea7542607eab984d3904f527ec24d4f6e0
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

          Message: WT-1481 Further regularize sweep stat naming.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/f1ed3b900e2c48fb9e00f3074c0effc11fd21aee

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: WT-1481 Further regularize sweep stat naming. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/f1ed3b900e2c48fb9e00f3074c0effc11fd21aee
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

          Message: Merge pull request #2104 from wiredtiger/sweep-stats

          WT-1481 Fix and clarify some sweep statistics.
          Branch: develop
          https://github.com/wiredtiger/wiredtiger/commit/405f45e1ef036b999b470dccb916d9b8bc4f3106

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: Merge pull request #2104 from wiredtiger/sweep-stats WT-1481 Fix and clarify some sweep statistics. Branch: develop https://github.com/wiredtiger/wiredtiger/commit/405f45e1ef036b999b470dccb916d9b8bc4f3106
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

          Message: WT-1481 Fix and clarify some sweep statistics.

          Merge pull request #2104 from wiredtiger/sweep-stats

          (cherry picked from commit 405f45e1ef036b999b470dccb916d9b8bc4f3106)
          Branch: mongodb-3.0
          https://github.com/wiredtiger/wiredtiger/commit/5167870ac7e1ab1d46af3af9eb54b91ee04b2735

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: WT-1481 Fix and clarify some sweep statistics. Merge pull request #2104 from wiredtiger/sweep-stats (cherry picked from commit 405f45e1ef036b999b470dccb916d9b8bc4f3106) Branch: mongodb-3.0 https://github.com/wiredtiger/wiredtiger/commit/5167870ac7e1ab1d46af3af9eb54b91ee04b2735
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'}

          Message: WT-1481 Fix the count of open files.
          Branch: mongodb-3.0
          https://github.com/wiredtiger/wiredtiger/commit/009216b9ee84635d622374dd6a418514f0730a32

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'michaelcahill', u'name': u'Michael Cahill', u'email': u'michael.cahill@mongodb.com'} Message: WT-1481 Fix the count of open files. Branch: mongodb-3.0 https://github.com/wiredtiger/wiredtiger/commit/009216b9ee84635d622374dd6a418514f0730a32

            People

            • Assignee:
              sue.loverso Sue LoVerso
              Reporter:
              michael.cahill Michael Cahill
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: