@michaelcahill, Coverity complains about the ret == 0 test at the end of the TXN_API_END_RETRY macro in half-a-dozen places in the code.

I'm pretty sure we don't need the ret == 0, I think the only path to the loop's test is the ret = 0; continue statement above it, but please check me.