Review one if check that seems inverted

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None

      We change the check:

          /*
           * When threads perform eviction, don't cache block manager structures (even across calls), we
           * can have a significant number of threads doing eviction at the same time with large items.
           * Ignore checkpoints, once the checkpoint completes, all unnecessary session resources will be
           * discarded.
           */
          if (!WT_SESSION_IS_CHECKPOINT(session))
      

      to the following check:

          /*
           * When threads perform eviction, don't cache block manager structures (even across calls), we
           * can have a significant number of threads doing eviction at the same time with large items.
           * Ignore checkpoints, once the checkpoint completes, all unnecessary session resources will be
           * discarded.
           */
          if (!WT_SESSION_IS_CHECKPOINT(session) || F_ISSET(session, WT_SESSION_CHECKPOINT_WORKER)) {
      

      Should it be
      ```
      if (!WT_SESSION_IS_CHECKPOINT(session) && !F_ISSET(session, WT_SESSION_CHECKPOINT_WORKER))
      ```

      We should also add comments to describe the change.

            Assignee:
            [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            Chenhao Qu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: