disagg: Fix unintentional skipping of non-tiered tests

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Test Python
    • None
    • Storage Engines - Foundations
    • None
    • None

      The disagg hook currently skips any tests or scenarios containing the string "tiered", however this means that any tests that utilise gen_tiered_storage_sources() will have their one "non_tiered" scenario skipped as well. 

       

          def should_skip(self, test) -> (bool, str):
              skip_categories = [
                  ("disagg",               "Disagg tests already turn on the proper stuff"),
                  ("inmem",                "In memory tests don't make sense with disagg storage"),
                  ...,
                  ...,
                  ("tiered",               "Tiered tests do not apply to disagg"),        ]
              for (skip_string, skip_reason) in skip_categories:
                  if skip_string in str(test):
                      return (True, skip_reason)
              return (False, None) 
      tiered_storage_sources = [
          ('dir_store', dict(is_tiered = True, ...)),
          (...),
          (...),
          ('non_tiered', dict(is_tiered = False)),
      ]

      This should be fixed so that "non_tiered" scenarios are no longer skipped.

       

            Assignee:
            [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            Alexander Pullen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: