-
Type:
Improvement
-
Resolution: Unresolved
-
Priority:
Minor - P4
-
None
-
Affects Version/s: None
-
Component/s: Test Python
-
None
-
Storage Engines - Foundations
-
None
-
3
There are a couple of places that do very similar things when searching for metadata. As an example, consider this sample from test_disagg_checkpoint_size04:
def get_database_size(self):
match = re.search(r'database_size=(\d+)', self.disagg_get_complete_checkpoint_meta())
assert(match)
return int(match.group(1))
Here, we search checkpoint metadata for the database size. We have a bunch of other similar functions – for example, layered64 looks for checksums, and layered75 looks for file IDs. We should refactor these to have one single utility for doing it.