Coverity analysis defect 203581 Unused value c = NULL in clayered_lookup()

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Gone away
    • Priority: Trivial - P5
    • None
    • Affects Version/s: None
    • Component/s: Cursors
    • Storage Engines - Transactions
    • None
    • None

      Minor Coverity unused value where c = NULL; is declared in __clayered_lookup() in cur_layered.c then immediately overwritten. 

      We can remove the c = NULL; declaration.

      1370static int
      1371__clayered_lookup(WT_SESSION_IMPL *session, WT_CURSOR_LAYERED *clayered, WT_ITEM *value)
      1372{
      1373    WT_CONNECTION_IMPL *conn;
      1374    WT_Public Jira Project Posting PolicyCURSOR *c;
      1375    WT_DECL_RET;
      1376    bool found, reset_ignore_prepare;
      1377
      
      CID 203581: (#1 of 1): Unused value (UNUSED_VALUE)
      assigned_pointer: Assigning value NULL to c here, but that stored value is overwritten before it can be used.
      1378    c = NULL;
      1379    conn = S2C(session);
      1380    found = false;
      1381    reset_ignore_prepare = false;
      1382
      1383    if (!conn->layered_table_manager.leader) {
      
      value_overwrite: Overwriting previous write to c with value from clayered->ingest_cursor.
      1384        c = clayered->ingest_cursor;

       

            Assignee:
            [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            Alana Huang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: