Make s_string use the correct aspell mode for different files

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Fixed
    • Priority: Minor - P4
    • WT12.0.0, 9.0.0-rc0
    • Affects Version/s: None
    • Component/s: Lint
    • None
    • Storage Engines - Foundations
    • 783.29
    • None
    • None

      Problem:

      s_string uses --mode=ccpp (C/C++ comment parser) for all files including .yml. .yml uses # comments, not /* */ or //, so comment typos in .yml files are not caught. This is also a problem if we decide to spell check more files e.g. python files or markdown files.

      Context:

      WT-17032 highlighted odd behaviour where two .yml files of identical content but different ordering flagged the spell checker. This is not intended behaviour.

      Definition of Done:

      • s_string uses the correct aspell mode based on the file extension
      • New file types can be added easily
      • New whitelist words surfaced by correct YAML checking are added to s_string.ok

       

            Assignee:
            Krishen Chovhan
            Reporter:
            Krishen Chovhan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: