Missing error message for __disagg_begin_checkpoint failure in __wt_disagg_advance_checkpoint

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Duplicate
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Checkpoints
    • Security Level: Public (Available to anyone on the web)
    • Storage Engines - Persistence
    • 1,583.139
    • None
    • 1

      Issue Summary

      The function _disagg_begin_checkpoint is invoked three times, and in two instances, it is properly wrapped with WT_ERR_MSG_CHK and the error message "Failed to begin a new checkpoint". However, the invocation inside _wt_disagg_advance_checkpoint does not include this error handling, resulting in a lack of informative error messages if this call fails.

      Context

      • Two out of three calls to __disagg_begin_checkpoint have appropriate error handling and messaging.
      • The call within __wt_disagg_advance_checkpoint is missing the WT_ERR_MSG_CHK wrapper and associated error message.
      • This inconsistency could hinder debugging and error tracing when checkpoint initiation fails at this location.

      Proposed Solution

      • Update the call to _disagg_begin_checkpoint inside _wt_disagg_advance_checkpoint to include the WT_ERR_MSG_CHK macro and the message "Failed to begin a new checkpoint", ensuring consistent error reporting across all usages.

      Original Slack thread: Slack Thread
      This ticket was generated by AI from a Slack thread.

            Assignee:
            Etienne Petrel
            Reporter:
            Memento Slack Bot
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: