Update the function signature for pl_get_complete_checkpoint

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Major - P3
    • WT12.0.0
    • Affects Version/s: None
    • Component/s: PALI
    • None
    • Storage Engines, Storage Engines - Persistence
    • 12.272
    • SE Persistence backlog
    • None

      The public PALI interface WT_PAGE_LOG has currently two versions of a function for returning the latest complete checkpoint:

      • pl_get_complete_checkpoint, which is the older interface that gets the latest checkpoint ID.
      • pl_get_complete_checkpoint_ext, which is a newer interface that returns additional values.

      We should consolidate the two functions and have only one function pl_get_complete_checkpoint with the right signature, and we should deprecate pl_get_complete_checkpoint_ext.

      We should future-proof the new signature for pl_get_complete_checkpoint by letting it fill out a struct, rather than individual fields as in the current implementation. We can use a struct similar to WT_PAGE_LOG_COMPLETE_CHECKPOINT_ARGS, or we can change that struct so that it can be reused for both completing checkpoints ands getting information about the latest completed checkpoint—but in that case, we would need to ensure compatibility with existing callers.

            Assignee:
            Albert Song
            Reporter:
            Peter Macko
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: