Remove redundant change_ref_state argument from __wt_split_rewrite

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: Reconciliation
    • None
    • Storage Engines - Transactions
    • 84.422
    • SE Transactions - 2026-07-03
    • 2

      The `change_ref_state` parameter in `__wt_split_rewrite` (`src/btree/bt_split.c`) is always passed as `true` by both of its callers (`src/evict/evict_page.c:668` and `src/evict/evict_page.c:712`). The conditional at the end of the function:

      if (change_ref_state)
          WT_REF_SET_STATE(ref, WT_REF_MEM);
      

      is therefore always taken. The parameter should be removed and `WT_REF_SET_STATE(ref, WT_REF_MEM)` called unconditionally. The function comment, declaration in `src/include/extern.h`, and both call sites should be updated accordingly.

            Assignee:
            [DO NOT USE] Backlog - Storage Engines Team
            Reporter:
            Chenhao Qu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: