Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-1811

Change sweep to not wait on the dhandle list lock

    Details

    • Type: Task
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      There is a bug I can't see and missed in the review.

      Original comment:
      Avoid a deadlock between the sweep server and a checkpoint.

      The sweep server was holding a handle exclusive and waiting on the handle list lock (in order to remove the handle from the list), a checkpoint was holding the handle list lock waiting for a read lock on the handle. Found by examining a hang during automated testing.

        Issue Links

          Activity

          Hide
          michael.cahill Michael Cahill added a comment -

          If we go with the change to sweep in WT-1812, where we only discard clean files, maybe we can afford to hold the data handle lock around the whole operation, so we don't have this lock ordering problem?

          Show
          michael.cahill Michael Cahill added a comment - If we go with the change to sweep in WT-1812 , where we only discard clean files, maybe we can afford to hold the data handle lock around the whole operation, so we don't have this lock ordering problem?
          Hide
          agorrod Alex Gorrod added a comment -

          autobuild: retest this please

          Show
          agorrod Alex Gorrod added a comment - autobuild: retest this please
          Hide
          michael.cahill Michael Cahill added a comment -

          Closing: I prefer the approach in WT-1819.

          Show
          michael.cahill Michael Cahill added a comment - Closing: I prefer the approach in WT-1819 .
          Hide
          ramon.fernandez Ramon Fernandez added a comment -

          Additional ticket information from GitHub

          Commits in this ticket:
          This ticket was referenced in the following commits:
          Show
          ramon.fernandez Ramon Fernandez added a comment - Additional ticket information from GitHub Commits in this ticket: 2c659bebc5c993760a362cb1fd393ec1e3c9156b This ticket was referenced in the following commits: 269e847ad64dd12dfcadb58f84f905069e5b8dce

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since reply:
                1 year, 48 weeks, 6 days ago
                Date of 1st Reply: